Fixup merge master into Chinese Word Segmentation#20055
Conversation
…zation and corresponding tests
…neseWordSegmentationStrategy
cary-rowen
left a comment
There was a problem hiding this comment.
Was this an unexpected change?
|
Hi @CrazySteve0605, I reviewed this PR against the Copilot comments from #19166. Most of the explicit comments are handled correctly, but I think two issues still need attention. First, the braille offset-converter issue is still unresolved. braille.py still keeps only one converter. When Chinese word-segmentation spacing is applied first and Unicode normalization is also enabled, the segmentation converter is overwritten by the normalization converter. As a result, Second, The rest of the fixes look broadly in the right direction to me. |
|
I will test the actual experience with Focus 80 later. The above is just a response to some points that Copilot raised that may need to be considered. |
…SegmentationStrategy
- use a list of converters for improved processing - add unit test for Chinese word segmentation and Unicode normalization offsets
|
While testing Chinese braille word segmentation, I found a regression: some NVDA built-in braille state abbreviations are being split by the word segmentation logic. For example, the checked state for a checkbox should remain This seems to happen because I think this should be fixed in this PR. A reasonable approach would be to avoid inserting word-segmentation separators between Braille Pattern characters, or more generally avoid inserting separators across symbol boundaries. It would also be good to add regression tests to ensure Btw, please remember to remove irrelevant .md file changes from the changes. Thanks |
|
Regarding Braille status abbreviations, please refer to this section in the user guide. |
…ional Unicode (e.g. braille) categories
|
Thanks @CrazySteve0605 The fix works for me. |
|
Hi @cary-rowen , thanks for reviews and testing. |
fab3060
into
nvaccess:try-chineseWordSegmentation-staging
Link to issue number:
Summary of the issue:
Description of user facing changes:
Description of developer facing changes:
Description of development approach:
Testing strategy:
Known issues with pull request:
Code Review Checklist: